Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5741#issuecomment-99202338
Hi @BryanCutler, thanks for the updates.
I realized that I between the time I dreamed of this in my head, and when I
actually created the jira, there was a layer of abstraction put in the RPC
layer. So in addition to `AkkaUtils.askWithReply`, we also want to fix
`AkkaRpcEnv.sendWithReply`, as that is where most of the calls are really being
made. As you pointed out, these timeouts are all created by
`RpcUtils.askTimeout` -- so how about we just change that method to always
return a `ConfiguredTimeout`?
Sorry I spec'ed this poorly in the beginning and to require more work on
this, but I feel pretty strongly that I want to make sure we get *all* of the
timeouts covered, and the best way to do that is make the compiler do the
checks for us. Also it makes me to want to fix `RpcUtils.lookupTimeout` as
well. Just changing `AkkaUtils.askWithReply` is still useful, so you dont'
have to take on the whole thing, but there's no huge time pressure so feel free
to keep going on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
