Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5741#discussion_r29708136
--- Diff: core/src/main/scala/org/apache/spark/util/AkkaUtils.scala ---
@@ -30,6 +34,61 @@ import org.apache.log4j.{Level, Logger}
import org.apache.spark.{Logging, SecurityManager, SparkConf, SparkEnv,
SparkException}
/**
+ * Associates a timeout with a configuration property so that a
TimeoutException can be
+ * traced back to the controlling property. The main constructor takes a
generic timeout
+ * and description while the auxilary constructor uses a specific property
defined in the
+ * given configuration.
+ * @param duration timeout duration in milliseconds
+ * @param description description to be displayed in a timeout exception
+ */
+class ConfiguredTimeout(duration: FiniteDuration, description: String) {
--- End diff --
this need to be scoped at least to `private[spark]`, possibly even tighter.
Same goes for other classes & methods. We can wait till the rest of the
design shakes out a little more before worrying about that too much, though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
