cloud-fan commented on a change in pull request #33624:
URL: https://github.com/apache/spark/pull/33624#discussion_r681986057
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -536,7 +523,7 @@ case class AdaptiveSparkPlanExec(
case s: ShuffleExchangeLike =>
val newShuffle = applyPhysicalRules(
s.withNewChildren(Seq(optimizedPlan)),
- postStageCreationRules,
+ postStageCreationRules(outputColumnar = false),
Review comment:
seems we don't need the post-stage creation extension rules at all if we
have an API `ShuffleExchangeLike.requiresColumnarInput` (or reuse
`SparkPlan.supportsColumnar`?). We can let the rule
`ApplyColumnarRulesAndInsertTransitions` to adjust the plan and always output
columnar format if the shuffle/broadcast needs columnar input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
