dongjoon-hyun commented on a change in pull request #33624:
URL: https://github.com/apache/spark/pull/33624#discussion_r682044610
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala
##########
@@ -521,7 +499,8 @@ case class RowToColumnarExec(child: SparkPlan) extends
RowToColumnarTransition {
* to/from columnar formatted data.
*/
case class ApplyColumnarRulesAndInsertTransitions(
- columnarRules: Seq[ColumnarRule])
+ columnarRules: Seq[ColumnarRule],
+ outputColumnar: Boolean = false)
Review comment:
Looks like a good idea.
BTW, since `ApplyColumnarRulesAndInsertTransitions` is used a few time,
shall we remove the default value?
```
sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala:case
class ApplyColumnarRulesAndInsertTransitions(
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala:
ApplyColumnarRulesAndInsertTransitions(sparkSession.sessionState.columnarRules),
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
ApplyColumnarRulesAndInsertTransitions(context.session.sessionState.columnarRules),
sql/core/src/test/scala/org/apache/spark/sql/execution/ColumnarRulesSuite.scala:
val rules = ApplyColumnarRulesAndInsertTransitions(
sql/core/src/test/scala/org/apache/spark/sql/execution/ColumnarRulesSuite.scala:
val rules = ApplyColumnarRulesAndInsertTransitions(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
