HyukjinKwon commented on a change in pull request #33624:
URL: https://github.com/apache/spark/pull/33624#discussion_r683057136



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala
##########
@@ -519,9 +497,13 @@ case class RowToColumnarExec(child: SparkPlan) extends 
RowToColumnarTransition {
 /**
  * Apply any user defined [[ColumnarRule]]s and find the correct place to 
insert transitions
  * to/from columnar formatted data.
+ *
+ * @param columnarRules custom columnar rules
+ * @param outputColumnar whether or not the produced plan should output 
columnar format.

Review comment:
       maybe `outputsColumnar` to match with `supportsColumnar` or 
`isOutputColumnar`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to