cloud-fan commented on a change in pull request #33624:
URL: https://github.com/apache/spark/pull/33624#discussion_r683149985
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -348,34 +344,24 @@ case class AdaptiveSparkPlanExec(
withFinalPlanUpdate(_.execute())
}
- /**
- * Determine if the final query stage supports columnar execution. Calling
this method
- * will trigger query execution of child query stages if they have not
already executed.
- *
- * If this method returns true then it is safe to call doExecuteColumnar to
execute the
- * final stage.
- */
- def finalPlanSupportsColumnar(): Boolean = {
- getFinalPhysicalPlan().supportsColumnar
- }
-
override def doExecuteColumnar(): RDD[ColumnarBatch] = {
withFinalPlanUpdate(_.executeColumnar())
}
+ override def doExecuteBroadcast[T](): broadcast.Broadcast[T] = {
Review comment:
it's not just moving around, it follows the other methods to also call
`withFinalPlanUpdate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
