Ngone51 commented on a change in pull request #33613:
URL: https://github.com/apache/spark/pull/33613#discussion_r683215389
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -164,10 +182,7 @@ private AppShufflePartitionInfo
getOrCreateAppShufflePartitionInfo(
// current incoming one
int latestShuffleMergeId =
appShuffleMergePartitionsInfo.shuffleMergeId;
if (latestShuffleMergeId > shuffleMergeId) {
- throw new StaleBlockPushException(String.format("Rejecting shuffle
blocks push request"
- + " for shuffle %s with shuffleMergeId %s for application %s_%s
as a higher"
- + " shuffleMergeId %s request is already seen", shuffleId,
shuffleMergeId,
- appShuffleInfo.appId, appShuffleInfo.attemptId,
latestShuffleMergeId));
Review comment:
Could we also log for the case of:
```
if (dataFile.exists()) {
return null;
}
```
Btw, is it equivalent to throw
`BlockPushNonFatalFailure(ReturnCode.TOO_LATE_BLOCK_PUSH)` rather than return
null? If it's equivalent, I think throwing exception is more consistent with
the case of "stale push"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
