Ngone51 commented on a change in pull request #33613:
URL: https://github.com/apache/spark/pull/33613#discussion_r685642507
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -748,20 +780,26 @@ private void incrementIOExceptionsAndAbortIfNecessary() {
}
/**
- * If appShuffleMergePartitionsInfo is null or shuffleMergePartitions is
set to
- * INDETERMINATE_SHUFFLE_FINALIZED or if the reduceId is not in the map
then the
- * shuffle is already finalized. Therefore the block push is too late. If
- * appShuffleMergePartitionsInfo's shuffleMergeId is
+ * If appShuffleMergePartitionsInfo's shuffleMergeId is
* greater than the request shuffleMergeId then it is a stale block push.
*/
- private boolean isStaleOrTooLate(
+ private boolean isStale(
AppShuffleMergePartitionsInfo appShuffleMergePartitionsInfo,
- int shuffleMergeId,
- int reduceId) {
+ int shuffleMergeId) {
+ return appShuffleMergePartitionsInfo.shuffleMergeId > shuffleMergeId;
+ }
+
+ /**
+ * If appShuffleMergePartitionsInfo is null or shuffleMergePartitions is
set to
+ * INDETERMINATE_SHUFFLE_FINALIZED or if the reduceId is not in the map
then the
+ * shuffle is already finalized. Therefore the block push is too late.
+ */
+ private boolean isTooLate(
+ AppShuffleMergePartitionsInfo appShuffleMergePartitionsInfo,
+ int reduceId) {
Review comment:
nit: 4 indents
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
