Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5908#discussion_r29733524
--- Diff:
core/src/main/scala/org/apache/spark/storage/ExternalBlockStore.scala ---
@@ -62,42 +62,50 @@ private[spark] class ExternalBlockStore(blockManager:
BlockManager, executorId:
values: Iterator[Any],
level: StorageLevel,
returnValues: Boolean): PutResult = {
- logDebug(s"Attempting to write values for block $blockId")
- val bytes = blockManager.dataSerialize(blockId, values)
- putIntoExternalBlockStore(blockId, bytes, returnValues)
+ putIntoExternalBlockStore(blockId, Left(values), returnValues)
}
private def putIntoExternalBlockStore(
blockId: BlockId,
- bytes: ByteBuffer,
+ data: Either[Iterator[_], ByteBuffer],
--- End diff --
Please don't use Either. I think it's easier to just break this into two
functions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
