Github user zhzhan commented on the pull request:
https://github.com/apache/spark/pull/5908#issuecomment-99317541
@shimingfei Some high level comments. I think putValue and putBytes,
getValues and getBytes are overlapping. putValue/getValue is an improvement.
Certainly plugin can implement both of them, but the shim layer does not need
to enforce it. Probably a fallback mechanism should be provided. For example,
putValues can have default implementation using putBytes, getValues can have
default implementation getBytes. putBytes/getBytes can follow the similar way.
Thus, user can implement all functions, or choose to fallback to the default.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
