Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5917#discussion_r29734484
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -389,9 +404,9 @@ private[spark] class MesosClusterScheduler(
}
val cmdExecutable = new File(executorSparkHome,
"./bin/spark-submit").getCanonicalPath
val cmdJar = desc.jarUrl.split("/").last
- s"$cmdExecutable ${cmdOptions.mkString(" ")} $cmdJar $appArguments"
+ (cmdExecutable, cmdJar)
}
- builder.setValue(cmd)
+ builder.setValue(s"$executable ${cmdOptions.mkString(" ")} $jar
$appArguments")
--- End diff --
in L373 up there can you just set `val cmdOptions =
generateCmdOptions(desc).mkString(" ")`, so this is easier to read? I believe
it's only used in one place so it's safe to do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
