Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/5917#discussion_r29776199
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -370,16 +370,30 @@ private[spark] class MesosClusterScheduler(
val executorOpts = desc.schedulerProperties.map { case (k, v) =>
s"-D$k=$v" }.mkString(" ")
envBuilder.addVariables(
Variable.newBuilder().setName("SPARK_EXECUTOR_OPTS").setValue(executorOpts))
- val cmdOptions = generateCmdOption(desc)
+ val cmdOptions = generateCmdOption(desc).mkString(" ")
+ val dockerDefined =
desc.schedulerProperties.contains("spark.mesos.executor.docker.image")
val executorUri = desc.schedulerProperties.get("spark.executor.uri")
.orElse(desc.command.environment.get("SPARK_EXECUTOR_URI"))
val appArguments = desc.command.arguments.mkString(" ")
- val cmd = if (executorUri.isDefined) {
+ val (executable, jar) = if (dockerDefined) {
+ val executorOpts = desc.schedulerProperties
--- End diff --
`SPARK_EXECUTOR_OPTS` is already set to all properties in
`desc.schedulerProperties` above. Do we need to set it for docker specific
properties again? Doesn't it overwrite the setting?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
