HeartSaVioR commented on pull request #33691: URL: https://github.com/apache/spark/pull/33691#issuecomment-896685699
I realized my bad after looking into your change... sorry about that. It doesn't make sense to filter out from all endpoints, as we will end up with touching everywhere which may feel odd. Let's just do what we've done with time window... We are no longer counting the case, but I think even we want to count the case when filtering out, we need a new local/physical plan to inject instead of injecting filter, instead of touching all endpoints. https://github.com/apache/spark/blob/f7c85b855ba99757c750dd0a2f7aced788c89374/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L3910-L3921 Sorry again for being back and forth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
