HeartSaVioR edited a comment on pull request #33691: URL: https://github.com/apache/spark/pull/33691#issuecomment-896693381
> I don't see in the SS guide we mention that the session's end time is the event time + gap duration of the last event? Do you mean this sentence? >> A session window closes when there's no input received within gap duration after receiving the latest input. > It looks like not saying that the session's end time is the event time + gap duration of the last event. The sentence only assumes static gap duration, and it's no longer true for dynamic gap duration. At least current logic won't work like so. We are technically "merging" sessions, which means the session's range is union of all merged sessions' range. It's simply possible that `earlier event + gap duration` is later than `latest event + gap duration`, and in this case the session's end time is `earlier event + gap duration` instead of `latest event + gap duration`. We probably need to explain the dynamic gap duration as a separate figure/sentence, so that end users can understand it is working as "merging" sessions, or if we don't like to expose technical aspect, union of sessions' range. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
