sunchao commented on a change in pull request #33695:
URL: https://github.com/apache/spark/pull/33695#discussion_r688858168
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetReadState.java
##########
@@ -131,9 +157,10 @@ long currentRangeEnd() {
* Advance the current offset and rowId to the new values.
*/
void advanceOffsetAndRowId(int newOffset, long newRowId) {
- valuesToReadInBatch -= (newOffset - offset);
+ rowsToReadInBatch -= (newOffset - levelOffset);
valuesToReadInPage -= (newRowId - rowId);
- offset = newOffset;
+ levelOffset = newOffset;
+ valueOffset = newOffset;
Review comment:
This method is only called for reading non-repeated values in which case
they are always the same. For the other case it is not through this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
