cloud-fan commented on a change in pull request #33650:
URL: https://github.com/apache/spark/pull/33650#discussion_r691740952
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala
##########
@@ -57,6 +63,30 @@ abstract class FileScanBuilder(
StructType(fields)
}
+ def pushFiltersToFileIndex(
Review comment:
this pushes data filters to the underlying file format as well. How about
```
protected var partitionFilters = Seq.empty[Expression]
protected var dataFilters = Seq.empty[Expression]
protected var pushedDataFilters = Seq.empty[Filter]
...
def pushFilters(partitionFilters: Seq[Expression], dataFilters:
Seq[Expression]): Unit = {
this.partitionFilters = partitionFilters
this.dataFilters = dataFilters
this.pushedDataFilters = pushDataFilters(dataFilters)
}
protected def pushDataFilters(dataFilters: Seq[Expression]) = Nil
```
Then file source impl can just override `pushDataFilters`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
