cloud-fan commented on a change in pull request #33650:
URL: https://github.com/apache/spark/pull/33650#discussion_r691852709
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScanBuilder.scala
##########
@@ -63,25 +65,13 @@ case class ParquetScanBuilder(
// The rebase mode doesn't matter here because the filters are used to
determine
// whether they is convertible.
LegacyBehaviorPolicy.CORRECTED)
- parquetFilters.convertibleFilters(this.filters).toArray
+ parquetFilters.convertibleFilters(translateDataFilter).toArray
Review comment:
Why do we care about partition filters in parquet filter pushdown? Can
you look into the source code and find the reason? Otherwise, we should always
use data filters. The previous code can be wrong/sub-optimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
