Peng-Lei commented on a change in pull request #33339:
URL: https://github.com/apache/spark/pull/33339#discussion_r696257549
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala
##########
@@ -46,6 +46,9 @@ class CatalogManager(
private val catalogs = mutable.HashMap.empty[String, CatalogPlugin]
def catalog(name: String): CatalogPlugin = synchronized {
+ if (name.trim.isEmpty) {
Review comment:
It is good that move `SessionCatalog.validateName` to a util function
and also apply the same check here. But I have a little doubt that does the
catalog name check need to be the same as that of the namespace/database and
table? Maybe it is a bit strict. The catalog name come from SparkConf instead
of SQL input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
