Peng-Lei commented on a change in pull request #33339:
URL: https://github.com/apache/spark/pull/33339#discussion_r696614174
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -566,8 +566,8 @@ object QueryCompilationErrors {
new AnalysisException(s"Database $db is not empty. One or more $details
exist.")
}
- def invalidNameForTableOrDatabaseError(name: String): Throwable = {
- new AnalysisException(s"`$name` is not a valid name for tables/databases.
" +
+ def invalidNameForCatalogOrDatabaseOrTableError(name: String): Throwable = {
Review comment:
another question: we could not use `org.apache.spark.sql.xxx` as v1
provider , eg:`avro,csv,json,kafka,orc,parquet,text`. because when try to
lookup catalog with multi name parts like `org.apache.spark.sql.xxx` `.``yyy`,
it will failed. `org.apache.spark.sql.xxx` is not valid name of catalog. The
catalog name could not contains `.`. So v1 provider can only be `orc` not
`org.apache.spark.sql.orc` and so on. [Test
case](https://github.com/apache/spark/blob/c7fa3c9090d88115c088570627138e1171c7a0eb/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala#L1379)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
