itholic commented on a change in pull request #33882:
URL: https://github.com/apache/spark/pull/33882#discussion_r700749810
##########
File path: python/pyspark/pandas/namespace.py
##########
@@ -2814,9 +2824,16 @@ def to_numeric(arg):
1.0
"""
if isinstance(arg, Series):
- return arg._with_new_scol(arg.spark.column.cast("float"))
+ if errors == "coerce":
+ return arg._with_new_scol(arg.spark.column.cast("float"))
+ elif errors == "raise":
+ raise NotImplementedError("'raise' is not implemented yet, when
the `arg` is Series.")
Review comment:
Just implemented `raise`, but I'm not sure if it's intended solution
mentioned from https://github.com/apache/spark/pull/33882#discussion_r699819419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
