itholic commented on a change in pull request #33882:
URL: https://github.com/apache/spark/pull/33882#discussion_r700997327
##########
File path: python/pyspark/pandas/namespace.py
##########
@@ -2747,13 +2747,20 @@ def merge(
@no_type_check
-def to_numeric(arg):
+def to_numeric(arg, errors="raise"):
Review comment:
Is it okay although pandas use `raise` as default ??
I worry about that maybe the existing pandas users want to `to_numeric` just
raise an Exception rather than change the value to `NaN` by default ?? - I have
not many context about in real world practice, though -
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
