HyukjinKwon commented on a change in pull request #33877:
URL: https://github.com/apache/spark/pull/33877#discussion_r703368553



##########
File path: python/pyspark/sql/utils.py
##########
@@ -210,3 +210,14 @@ def to_str(value):
         return value
     else:
         return str(value)
+
+
+def is_timestamp_ntz_preferred():

Review comment:
       We can. I took this out of `SparkSession` because
   1. there are some places like `types.py` where some methods can be accessed 
without initiating `SparkSession`
   2. it doesn't require any properties in `SparkSession` instance
   3. some tests fail for `SQLContext` (e.g., 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143016/console)
   4. When `SparkContext` or `SparkSession` is stopped, JVM is still supposed 
to be alive in PySpark. It's safer to don't assume on `SparkSession`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to