cloud-fan commented on a change in pull request #33877:
URL: https://github.com/apache/spark/pull/33877#discussion_r703517710
##########
File path: python/pyspark/pandas/data_type_ops/datetime_ops.py
##########
@@ -58,15 +66,18 @@ def sub(self, left: IndexOpsLike, right: Any) ->
SeriesOrIndex:
"The timestamp subtraction returns an integer in seconds, "
"whereas pandas returns 'timedelta64[ns]'."
)
- if isinstance(right, IndexOpsMixin) and
isinstance(right.spark.data_type, TimestampType):
+ if isinstance(right, IndexOpsMixin) and isinstance(
+ right.spark.data_type, (TimestampType, TimestampNTZType)
+ ):
warnings.warn(msg, UserWarning)
return left.astype("long") - right.astype("long")
Review comment:
Not very familiar with pandas. Can you give a real example that will hit
this code path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
