rmcyang commented on a change in pull request #33976:
URL: https://github.com/apache/spark/pull/33976#discussion_r707568147
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2597,14 +2597,29 @@ private[spark] object Utils extends Logging {
}
/**
- * Push based shuffle can only be enabled when the application is submitted
- * to run in YARN mode, with external shuffle service enabled
+ * Push based shuffle can only be enabled when below conditions are met:
+ * - the application is submitted to run in YARN mode
+ * - external shuffle service enabled
+ * - IO encryption disabled
+ * - serializer(such as KryoSerializer) supports relocation of serialized
objects
*/
def isPushBasedShuffleEnabled(conf: SparkConf): Boolean = {
- conf.get(PUSH_BASED_SHUFFLE_ENABLED) &&
- (conf.get(IS_TESTING).getOrElse(false) ||
- (conf.get(SHUFFLE_SERVICE_ENABLED) &&
- conf.get(SparkLauncher.SPARK_MASTER, null) == "yarn"))
+ val serializer =
Utils.classForName(conf.get(SERIALIZER)).getConstructor(classOf[SparkConf])
+ .newInstance(conf).asInstanceOf[Serializer]
+ val doPushBasedShuffle =
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
