zhouyejoe commented on a change in pull request #33976:
URL: https://github.com/apache/spark/pull/33976#discussion_r707591530
##########
File path: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala
##########
@@ -1510,9 +1510,16 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProperties with Logging {
conf.set(SHUFFLE_SERVICE_ENABLED, true)
conf.set(SparkLauncher.SPARK_MASTER, "yarn")
conf.set("spark.yarn.maxAttempts", "1")
Review comment:
Same here. Change the key to the correct ones
`spark.yarn.maxAppAttempts`
##########
File path: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala
##########
@@ -1510,9 +1510,16 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProperties with Logging {
conf.set(SHUFFLE_SERVICE_ENABLED, true)
conf.set(SparkLauncher.SPARK_MASTER, "yarn")
conf.set("spark.yarn.maxAttempts", "1")
+ conf.set(SERIALIZER, "org.apache.spark.serializer.KryoSerializer")
assert(Utils.isPushBasedShuffleEnabled(conf) === true)
conf.set("spark.yarn.maxAttempts", "2")
assert(Utils.isPushBasedShuffleEnabled(conf) === true)
Review comment:
My fault. The correct key should be for spark.yarn.maxAppAttempts. This
was added during the time when we can not enable push based shuffle if there
are multiple attempts configured. But now that constraints has been removed.
Please also help change the key to spark.yarn.maxAppAttempts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
