mridulm commented on a change in pull request #34018:
URL: https://github.com/apache/spark/pull/34018#discussion_r710318332
##########
File path: core/src/main/scala/org/apache/spark/SparkEnv.scala
##########
@@ -355,6 +355,11 @@ object SparkEnv extends Logging {
None
}
+ // Set the application attemptId in the ExternalShuffleClient is
applicable.
+ // If there is no attemptId assigned, set the attemptId to -1.
+ externalShuffleClient.foreach(
+ shuffleClient =>
shuffleClient.setAppAttemptId(conf.getInt(config.APP_ATTEMPT_ID.key, -1)))
Review comment:
Yes, we should not set it here - but along with existing
`APP_ATTEMPT_ID` set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
