mridulm commented on a change in pull request #34018:
URL: https://github.com/apache/spark/pull/34018#discussion_r710318332
##########
File path: core/src/main/scala/org/apache/spark/SparkEnv.scala
##########
@@ -355,6 +355,11 @@ object SparkEnv extends Logging {
None
}
+ // Set the application attemptId in the ExternalShuffleClient is
applicable.
+ // If there is no attemptId assigned, set the attemptId to -1.
+ externalShuffleClient.foreach(
+ shuffleClient =>
shuffleClient.setAppAttemptId(conf.getInt(config.APP_ATTEMPT_ID.key, -1)))
Review comment:
There are two cases here:
* SparkEnv created in executors - for which this set is fine (which will
need attempt id for block push).
* SparkEnv created at driver - for which `APP_ATTEMPT_ID` is available much
later in SparkContext initialization : we should do a `setAppAttemptId` along
with setting `APP_ATTEMPT_ID` for the `externalShuffleClient` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
