zhouyejoe commented on pull request #34018: URL: https://github.com/apache/spark/pull/34018#issuecomment-921955509
> Discussed with @Ngone51. > @zhouyejoe can we make the following change please: > > * Move toInt from SparkContext into setAttemptId (which will take it as a `String` param). > * try/catch the `Integer.parseInt` and log warning in case it is not able to parse attempt id to string. > > * If successful, set attempt id to that value - else leave it unchanged (defaulting to -1). > * Let us keep the attempt id in BlockStoreClient itself. > > Thoughts ? SGTM. Will update accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
