zhouyejoe commented on a change in pull request #34018:
URL: https://github.com/apache/spark/pull/34018#discussion_r711408419
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java
##########
@@ -146,7 +146,7 @@ public void pushBlocks(
assert inputListener instanceof BlockPushingListener :
"Expecting a BlockPushingListener, but got " +
inputListener.getClass();
TransportClient client = clientFactory.createClient(host, port);
- new OneForOneBlockPusher(client, appId,
transportConf.appAttemptId(), inputBlockId,
+ new OneForOneBlockPusher(client, appId, appAttemptId,
inputBlockId,
Review comment:
Changed to use comparableAppAttemptId, and since it is private var, so I
don't choose to use the getAppAttemptId() here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
