viirya commented on a change in pull request #34051:
URL: https://github.com/apache/spark/pull/34051#discussion_r715741737
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
##########
@@ -172,8 +172,7 @@ object PartitionPruning extends Rule[LogicalPlan] with
PredicateHelper with Join
// We can't reuse the broadcast because the join type doesn't support
broadcast,
// and doing DPP means running an extra query that may have significant
overhead.
// We need to make sure the pruning side is very big so that DPP is
still worthy.
- canBroadcastBySize(otherPlan, conf) &&
Review comment:
As this is not a broadcast join case, and we don't need broadcast it, if
we really need a size check, we should use another config for the purpose.
`autoBroadcastJoinThreshold` doesn't look like a good option because its
meaning doesn't fit here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
