viirya commented on a change in pull request #34051:
URL: https://github.com/apache/spark/pull/34051#discussion_r717269167
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/PlanAdaptiveSubqueries.scala
##########
@@ -43,7 +43,7 @@ case class PlanAdaptiveSubqueries(
}
)
}
- InSubqueryExec(expr, subqueryMap(exprId.id), exprId)
+ InSubqueryExec(expr, subqueryMap(exprId.id), exprId, shouldBroadcast =
true)
Review comment:
This seems not for DPP. DPP in logical plan will be
`DynamicPruningSubquery`. We transform it to
`DynamicPruningExpression(InSubqueryExec(...))`.
For example, you can change this line to `shouldBroadcast = false` and still
pass DPP test suites.
That is why I updated the doc of `InSubqueryExec`. Previously it said it is
for DPP only, but it is not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
