JoshRosen commented on pull request #33989: URL: https://github.com/apache/spark/pull/33989#issuecomment-926906688
A cross-reference for other reviewers: Given that `hive-exec` shades Guava in Hive 2.3.8+ (https://github.com/apache/hive/pull/1356), I was initially confused about why we needed to do our own shading in this PR: I originally thought that it was done to shade a broader set of dependencies beyond just Guava, further isolating us from future dependency conflicts. As @viirya points out at https://github.com/apache/spark/pull/29326#issuecomment-875060042, though, Spark uses the `hive-exec-core` JAR, not `hive-exec`, so Hive's Guava shading doesn't apply (hence the need to shade here). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
