Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5984#discussion_r29907627
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/rows.scala
---
@@ -197,7 +217,17 @@ class GenericMutableRow(v: Array[Any]) extends
GenericRow(v) with MutableRow {
override def setFloat(ordinal: Int, value: Float): Unit = {
values(ordinal) = value }
override def setInt(ordinal: Int, value: Int): Unit = { values(ordinal)
= value }
override def setLong(ordinal: Int, value: Long): Unit = {
values(ordinal) = value }
- override def setString(ordinal: Int, value: String) { values(ordinal) =
UTF8String(value)}
+ override def setString(ordinal: Int, value: String): Unit =
+ { values(ordinal) = UTF8String(value) }
--- End diff --
Super minor style nit, but I think the braces here should be on separate
lines, like how `setDate` is defined below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
