Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5984#discussion_r29907803
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
 ---
    @@ -223,6 +227,16 @@ public void setString(int ordinal, String value) {
       }
     
       @Override
    +  public void setDate(int ordinal, Date value) {
    +    throw new UnsupportedOperationException();
    --- End diff --
    
    Date is a fixed-width type that's stored in the primitive values section, 
so I think that we should be able to support in-place updates to it.  I think 
that we can just move the `setInt` call from `DateUnsafeColumnWriter` to here, 
then update that method to call `target.setDate` here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to