Github user harsha2010 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5830#discussion_r29912114
--- Diff: mllib/src/main/scala/org/apache/spark/ml/reduction/OneVsAll.scala
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ml.reduction
+
+import scala.language.existentials
+import scala.reflect.ClassTag
+
+import org.apache.spark.annotation.{AlphaComponent, Experimental}
+import org.apache.spark.ml.attribute.BinaryAttribute
+import org.apache.spark.ml.classification.{ClassificationModel,
Classifier, ClassifierParams}
+import org.apache.spark.ml.impl.estimator.{PredictionModel, Predictor}
+import org.apache.spark.ml.param.ParamMap
+import org.apache.spark.ml.util.{MetadataUtils, SchemaUtils}
+import org.apache.spark.mllib.linalg.Vector
+import org.apache.spark.rdd.RDD
+import org.apache.spark.sql.{DataFrame, Row}
+import org.apache.spark.sql.functions._
+import org.apache.spark.sql.types._
+import org.apache.spark.storage.StorageLevel
+
+/**
+ * Model produced by [[OneVsAll]].
+ *
+ * @param parent
+ * @param models the binary classification models for reduction.
+ */
+@AlphaComponent
+class OneVsAllModel[
+ FeaturesType,
+ E <: Classifier[FeaturesType, E, M],
+ M <: ClassificationModel[FeaturesType, M]](
+ override val parent: OneVsAll[FeaturesType, E, M],
+ val models: Array[M])
+ extends PredictionModel[FeaturesType, OneVsAllModel[FeaturesType, E, M]]
+ with ClassifierParams {
--- End diff --
Doesn' this cause a confusion? If OneVsAll implements PredictorParams , and
it takes a Classifier as input. Do users set rawPredictionCol in the Classifier
and the rest of the parameters in OneVsAll?
The way I was thinking to avoid this confusion was to accept all the
parameters that can be set on a classifier directly on the reduction (OneVsAll)
and ignore any settings on the Classifier itself.
I think your suggestion if i read it right is to have two independent set
of configurations (one for the underlying classifier and one for the
reduction). is that right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
