zero323 commented on a change in pull request #34238:
URL: https://github.com/apache/spark/pull/34238#discussion_r725992060
##########
File path: python/pyspark/conf.py
##########
@@ -18,6 +18,9 @@
__all__ = ['SparkConf']
import sys
+from typing import Optional, List, Tuple, Dict, overload
+
+from py4j.java_gateway import JVMView, JavaObject
Review comment:
It might be better to keep it in `TYPE_CHECKING` conditional, since this
is what we do in other migrated contexts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
