zero323 commented on a change in pull request #34238:
URL: https://github.com/apache/spark/pull/34238#discussion_r725996203
##########
File path: python/pyspark/context.py
##########
@@ -118,20 +134,36 @@ class SparkContext(object):
ValueError: ...
"""
- _gateway = None
- _jvm = None
+ _gateway = None # type: JavaGateway
+ _jvm = None # type: JavaObject
_next_accum_id = 0
- _active_spark_context = None
+ _active_spark_context = None # type: SparkContext
_lock = RLock()
- _python_includes = None # zip and egg files that need to be added to
PYTHONPATH
-
- PACKAGE_EXTENSIONS = ('.zip', '.egg', '.jar')
-
- def __init__(self, master=None, appName=None, sparkHome=None, pyFiles=None,
- environment=None, batchSize=0, serializer=PickleSerializer(),
conf=None,
- gateway=None, jsc=None, profiler_cls=BasicProfiler):
- if (conf is None or
- conf.get("spark.executor.allowSparkContext", "false").lower()
!= "true"):
+ # zip and egg files that need to be added to PYTHONPATH
+ _python_includes: List[str] = None # type: ignore[assignment]
+
+ PACKAGE_EXTENSIONS: Iterable[str] = ('.zip', '.egg', '.jar')
Review comment:
`Tuple[str, ...]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
