zero323 commented on a change in pull request #34227:
URL: https://github.com/apache/spark/pull/34227#discussion_r726570201
##########
File path: python/pyspark/pandas/frame.py
##########
@@ -10974,7 +10979,7 @@ def quantile(psser: "Series") -> Column:
# |[2, 3, 4]|[6, 7, 8]|
# +---------+---------+
- cols_dict = OrderedDict() # type: OrderedDict
+ cols_dict: OrderedDict = OrderedDict()
Review comment:
My intuition is that we get more from specifying key and value types,
than knowing that it is specifically `OrderedDict`. For all supported versions
`dict` is already ordered and the only method that is specific to `OrderedDict`
(`move_to_end`) is not used here. But I don't have very strong feelings about
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
