ueshin commented on a change in pull request #34227:
URL: https://github.com/apache/spark/pull/34227#discussion_r726581295
##########
File path: python/pyspark/pandas/namespace.py
##########
@@ -1378,11 +1383,11 @@ def read_sql_table(
reader.options(**options)
sdf = reader.format("jdbc").load()
index_spark_columns, index_names = _get_index_map(sdf, index_col)
- psdf = DataFrame(
+ psdf: DataFrame = DataFrame(
Review comment:
Or use `type: ignore[no-untyped-def]` instead of `no_type_check`
```py
# test.py
class Foo:
def __init__(self): # type: ignore[no-untyped-def]
pass
reveal_type(Foo())
```
```
% mypy test.py
test.py:7: note: Revealed type is "test.Foo"
```
Let me use `type: ignore[no-untyped-def]` here for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
