HyukjinKwon commented on a change in pull request #34272:
URL: https://github.com/apache/spark/pull/34272#discussion_r728551885
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -301,7 +301,7 @@ object JdbcUtils extends Logging with SQLConfHelper {
rsmd.getClass.getName ==
"org.apache.hive.jdbc.HiveResultSetMetaData" => true
}
}
- val nullable = if (alwaysNullable) {
+ val nullable = if (alwaysNullable ||
typeName.toString().equals("TIMESTAMP")) {
Review comment:
Can you elabourate why we should force timestamp as nullable alone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
