senthh commented on a change in pull request #34272:
URL: https://github.com/apache/spark/pull/34272#discussion_r728590774
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
##########
@@ -1328,7 +1328,7 @@ class JDBCSuite extends QueryTest
assert(df.schema.size === 2)
val expectedSchema = new
StructType(CatalystSqlParser.parseTableSchema(customSchema).map(
f => StructField(f.name, f.dataType, f.nullable,
defaultMetadata)).toArray)
- assert(df.schema === expectedSchema)
+ assert(!(df.schema === expectedSchema))
Review comment:
@HyukjinKwon
'expectedSchema' always expecting 'nullable' value as true, but after this
change we will get nullable value from SQL, so we can not ensure that nullable
will always be 'true'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
