cloud-fan commented on a change in pull request #34148:
URL: https://github.com/apache/spark/pull/34148#discussion_r728858987
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala
##########
@@ -128,7 +128,7 @@ private case object MySQLDialect extends JdbcDialect with
SQLConfHelper {
indexProperties = indexProperties + " " + s"$k $v"
}
}
- val iType = if (indexType.isEmpty) {
+ val iType = if (indexType == null || indexType.isEmpty) {
Review comment:
can we make it clear in the API doc? It seems better to avoid null, and
we can write in the doc that Spark will pass empty string if index type is not
specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
