cloud-fan commented on a change in pull request #34148:
URL: https://github.com/apache/spark/pull/34148#discussion_r729830325
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -1056,3 +1056,18 @@ case class UncacheTable(
override def markAsAnalyzed(): LogicalPlan = copy(isAnalyzed = true)
}
+
+/**
+ * The logical plan of the CREATE INDEX command.
+ */
+case class CreateIndex(
+ child: LogicalPlan,
+ indexName: String,
+ indexType: String,
+ ignoreIfExists: Boolean,
+ columns: Seq[NamedReference],
Review comment:
shall we combine it? `columns: Seq[NamedReference -> Map[String,
String]]`
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -1056,3 +1056,18 @@ case class UncacheTable(
override def markAsAnalyzed(): LogicalPlan = copy(isAnalyzed = true)
}
+
+/**
+ * The logical plan of the CREATE INDEX command.
+ */
+case class CreateIndex(
+ child: LogicalPlan,
+ indexName: String,
+ indexType: String,
+ ignoreIfExists: Boolean,
+ columns: Seq[NamedReference],
Review comment:
shall we combine it? `columns: Seq[(NamedReference, Map[String,
String])]`
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateIndexExec.scala
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import java.util
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.analysis.IndexAlreadyExistsException
+import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.connector.catalog.Table
+import org.apache.spark.sql.connector.catalog.index.SupportsIndex
+import org.apache.spark.sql.connector.expressions.NamedReference
+
+/**
+ * Physical plan node for creating an index.
+ */
+case class CreateIndexExec(
+ table: Table,
Review comment:
```suggestion
table: SupportsIndex,
```
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -429,6 +432,17 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
val table = a.table.asInstanceOf[ResolvedTable]
AlterTableExec(table.catalog, table.identifier, a.changes) :: Nil
+ case CreateIndex(ResolvedTable(_, _, table, _),
+ indexName, indexType, ifNotExists, columns, columnProperties,
properties) =>
+ table match {
+ case _: SupportsIndex =>
+ CreateIndexExec(table, indexName, indexType, ifNotExists, columns,
+ columnProperties, properties):: Nil
+ case _ => throw new SQLFeatureNotSupportedException(s"CreateIndex not
supported yet." +
Review comment:
Let's move it to `QueryCompilationErrors`.
The error message should highlight that it's this table that does not
support `CREATE INDEX`, not Spark.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -429,6 +432,17 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
val table = a.table.asInstanceOf[ResolvedTable]
AlterTableExec(table.catalog, table.identifier, a.changes) :: Nil
+ case CreateIndex(ResolvedTable(_, _, table, _),
+ indexName, indexType, ifNotExists, columns, columnProperties,
properties) =>
+ table match {
+ case _: SupportsIndex =>
+ CreateIndexExec(table, indexName, indexType, ifNotExists, columns,
+ columnProperties, properties):: Nil
+ case _ => throw new SQLFeatureNotSupportedException(s"CreateIndex not
supported yet." +
Review comment:
Let's move it to `QueryCompilationErrors`.
The error message should highlight that it's this table that does not
support `INDEX`, not Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
