zero323 commented on a change in pull request #34318:
URL: https://github.com/apache/spark/pull/34318#discussion_r733148023
##########
File path: python/pyspark/sql/observation.py
##########
@@ -14,17 +14,16 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-from typing import Any, Dict, Optional, TYPE_CHECKING
+from typing import Any, Dict, Optional
+
+from py4j.java_gateway import JavaObject, JVMView
Review comment:
Personally, I have a preference for adding ignores to imports that have
no stubs or built-in annotations, because it clearly indicates that we don't
expect these things to typecheck. And these take precedence over external
config, so I can easily experiment with different options. But I am fine with
either approach, as long as we are consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
