zero323 commented on a change in pull request #34318:
URL: https://github.com/apache/spark/pull/34318#discussion_r733153779
##########
File path: python/pyspark/pandas/data_type_ops/base.py
##########
@@ -395,7 +395,7 @@ def eq(self, left: IndexOpsLike, right: Any) ->
SeriesOrIndex:
collected_structed_scol = F.collect_list(structed_scol)
# Sort the array by NATURAL_ORDER_COLUMN so that we can guarantee
the order.
collected_structed_scol = F.array_sort(collected_structed_scol)
- right_values_scol = F.array([F.lit(x) for x in right]) # type:
ignore
+ right_values_scol = F.array(*(F.lit(x) for x in right))
Review comment:
Seems like we should add an overload to `array`, right?
```python
@overload
def array(cols: Union[List["ColumnOrName"], Tuple["ColumnOrName", ...]]) ->
Column:
...
@overload
def array(*cols: "ColumnOrName") -> Column:
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
