zero323 commented on a change in pull request #34411:
URL: https://github.com/apache/spark/pull/34411#discussion_r738234250
##########
File path: python/pyspark/conf.py
##########
@@ -195,21 +217,21 @@ def get(self, key, defaultValue=None):
else:
return self._conf.get(key, defaultValue)
- def getAll(self):
+ def getAll(self) -> Union[List[Tuple[str, str]], ItemsView[Any, Any]]:
Review comment:
Let's avoid `Union` types in return. Even when they're necessary (i.e.
`Optional`) they're real pain to use.
At minimum, we can use `Collection[Tuple[str, str]]`, but it might be better
to covert in L227
```python
return list(self._conf.items())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
