zero323 commented on a change in pull request #34411:
URL: https://github.com/apache/spark/pull/34411#discussion_r738229515
##########
File path: python/pyspark/conf.py
##########
@@ -122,9 +126,9 @@ def __init__(self, loadDefaults=True, _jvm=None,
_jconf=None):
else:
# JVM is not created, so store data in self._conf first
self._jconf = None
- self._conf = {}
+ self._conf = {} # type: ignore[var-annotated]
Review comment:
We should probably have this annotated at the top level.
```python
_jconf: Optional[JavaObject]
_conf: Optional[Dict[str, str]]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
