cloud-fan commented on a change in pull request #34474:
URL: https://github.com/apache/spark/pull/34474#discussion_r742639262
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/AggregatingAccumulator.scala
##########
@@ -185,9 +194,26 @@ class AggregatingAccumulator private(
// query execution).
createBuffer()
}
+ }
+
+ override def value: InternalRow = withSQLConf(false, InternalRow.empty) {
+ val input = getOrCreateTempBuffer()
resultProjection(input)
}
+ override def withBufferSerialized(): AggregatingAccumulator = {
+ if (!isAtDriverSide) {
+ val input = getOrCreateTempBuffer()
Review comment:
why do we need to create temp buffer here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
