c21 commented on a change in pull request #34540:
URL: https://github.com/apache/spark/pull/34540#discussion_r747116064
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -151,9 +144,10 @@ case class RowDataSourceScanExec(
Map(
"ReadSchema" -> requiredSchema.catalogString,
- "PushedFilters" -> seqToString(markedFilters.toSeq),
- "PushedAggregates" -> aggString,
- "PushedGroupby" -> groupByString) ++
+ "PushedFilters" -> seqToString(markedFilters.toSeq)) ++
+ pushedDownOperators.aggregation.fold(Map[String, String]()) { v =>
+ Map("PushedAggregates" -> seqToString(v.aggregateExpressions),
+ "PushedGroupby" -> seqToString(v.groupByColumns))} ++
Review comment:
@sunchao had a nit comment to rename to `PushedGroupBy` in
https://github.com/apache/spark/pull/34498#discussion_r744076628 . Though I
feel `PushedGroupByColumns` are better. To me, it seems to mean the same thing
between `aggregate` and `group by`.
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala
##########
@@ -344,8 +344,7 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession
with ExplainSuiteHel
case _: DataSourceV2ScanRelation =>
val expected_plan_fragment =
"PushedAggregates: [MAX(ID), MIN(ID)], " +
- "PushedFilters: [IsNotNull(ID), GreaterThan(ID,0)], " +
- "PushedGroupby: []"
Review comment:
don't we print `PushedAggregates` and `PushedGroupby` together in
`DataSourceScanExec.scala`? Why remove `PushedGroupby` only here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
