huaxingao commented on a change in pull request #34540:
URL: https://github.com/apache/spark/pull/34540#discussion_r747178536
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -151,9 +144,10 @@ case class RowDataSourceScanExec(
Map(
"ReadSchema" -> requiredSchema.catalogString,
- "PushedFilters" -> seqToString(markedFilters.toSeq),
- "PushedAggregates" -> aggString,
- "PushedGroupby" -> groupByString) ++
+ "PushedFilters" -> seqToString(markedFilters.toSeq)) ++
+ pushedDownOperators.aggregation.fold(Map[String, String]()) { v =>
+ Map("PushedAggregates" -> seqToString(v.aggregateExpressions),
+ "PushedGroupby" -> seqToString(v.groupByColumns))} ++
Review comment:
Changed to `PushedGroupByColumns`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala
##########
@@ -344,8 +344,7 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession
with ExplainSuiteHel
case _: DataSourceV2ScanRelation =>
val expected_plan_fragment =
"PushedAggregates: [MAX(ID), MIN(ID)], " +
- "PushedFilters: [IsNotNull(ID), GreaterThan(ID,0)], " +
- "PushedGroupby: []"
Review comment:
OK. I see what you mean now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
